Closed l-althueser closed 6 years ago
Thanks @l-althueser , do you have a few plots to check/validate the outcome of this update?
@l-althueser Did you find the exact commit in which the MC geometry changed? I recently moved all the 1T geometry definitions into the separate 1tTPC class, but ran several tests to confirm that nothing moved. Just to make sure I didn't mess things up, could you confirm you are referring to the changes introduced by Pietro in this PR?
OK, got some information by @feigaodm (thanks!). I understand now that the conflict comes after the nSort_py
stage and that pax was simply needing the new maps, adapted to the changes in Z introduced by Pietro on the geometry. You can forget about my question, @l-althueser 😄.
@feigaodm I checked the map itself in the notebooks but didn't compared to the previous map. I wouldn't expect any significant difference other than the geometry change. So the bottom PMTs max LCE area is now shifted a bit down to the correct place. Also, the S1 map is interpolated anyway which should compensate a lot. I can try to put together a diagnostics notebook which one can use to compare any of these maps in the future. Unfortunately, I can not compare the simulations directly since I deleted the old ones already to save space ... ;)
@feigaodm You can find the diagnostics and comparison pots/data in the diagnostics notebook on GitHub. I don't know if I am allowed to post plots that can easily be obtained from the maps of this repository directly. Please look at the histo plots for S1 and S2, both show a small difference for top channels (~2% for S1, ...).
The geometry of the MC simulation has changed by a few millimeters which made it necessary to regenerate the per-PMT simulations and extract all maps with a proper coordinate system.
changed maps
XENON1T_s1_xyz_patterns_interp_corrected_MCv2.4.1.json.gz
, binned with a coarse (r, phi, z) binning. Then, since PatternFitter requires a regular/Cartesian map, use the InterpolateAndExtrapolate to generate the map for use in PAX. Not interpolated map directly binned with Cartesian map is also available on midway.Extract LCE with: Number of bins in R: 5 Number of bins in Phi: [4, 6, 8, 12, 12] Number of bins in z: 60
Interpolate to PAX map with: Number of bins in x: 23 Number of bins in y: 23 Number of bins in z: 60