Closed jpienaar13 closed 6 years ago
Hi Jacques,
Your changes look good overall. I did notice a few things:
Hi @sthapa
For points 1 and 2 in combination:
3.) Implemented
4.) Changed
5.) Fixed
Oh wait, didnt fix your first point correctly
Ah, I didn't catch the change to use parse_known_args. The indexing now makes sense.
Added cases into the two macros to allow for switching between XENON1T and XENOnT geometries. At the moment all this should do is select the appropriate macro directory in the MC code, and exit the production chain after the G4 stage.
Will continue to propogate as other parts of the code get upgraded. Should be merged with https://github.com/XENON1T/mc/pull/103. (Which is ready to merge as soon as this is approved.)