Add efield position dependence

XENONnT / appletree

A high-performance program simulates and fits response of XENON

BSD 3-Clause "New" or "Revised" License

8 stars 2 forks source link

Add efield position dependence #188

Open mhliu0001 opened 1 month ago

mhliu0001 commented 1 month ago

Previously, only one uniform electric field was used. This PR adds position dependence to the electric field.

Another change is that I have unified the nestv2 parameter name with the other yield models. The field parameter was called "literature_field" before, and we should change it to "field" to avoid confusion.

mhliu0001 commented 1 month ago

I need to write a test for the field dependence.

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 11095259874

Details

24 of 24 (100.0%) changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 85.347%

Totals
Change from base Build 10709265769:	0.2%
Covered Lines:	2458
Relevant Lines:	2880

💛 - Coveralls

dachengx commented 1 month ago

LGTM

We will need to change parameters["field"] in https://github.com/XENONnT/applefiles accordingly.
This PR is not for production in SR1. So it is not in a hurry to merge it now.