search

XENONnT / epix

Electron and Photon Instructions generator for XENON
BSD 3-Clause "New" or "Revised" License
2 stars 1 forks source link

Fix for interaction classification parameters which are passed to NEST. #44

Closed PavelKavrigin closed 2 years ago

PavelKavrigin commented 2 years ago

This PR fixes the issue reported here:

#43

There's one thing which needs to be clarified - what is the proper parameter to pass in case of Kr83m:

NEST.cpp#L830-L831

The mass number we pass to this function actually serves as maxTimeSeparation which is passed to

NEST.cpp#L618

We pass 'infinity' here, which makes sense. However, please look at these NEST lines to double-check it.

HenningSE commented 2 years ago

Good catch @PavelKavrigin, I think we could also set the mass number to 0 for all cases except Kr83m and ions. NEST has a check here looking for a mass number of 0: https://github.com/NESTCollaboration/nest/blob/cfecfdb8dc474eeff08163a361cfad58173ba93e/src/NEST.cpp#L429-L430. In this case a random xenon isotope is used: https://github.com/NESTCollaboration/nest/blob/master/src/RandomGen.cpp#L110-L133 (I guess they are using the natural abundances of xenon isotopes here)

PavelKavrigin commented 2 years ago

Thanks! I've corrected it. I will run some tests now.