XENONnT / straxen

Streaming analysis for XENON
BSD 3-Clause "New" or "Revised" License
20 stars 32 forks source link

Move `get_window_size` factor of merged_s2s as untracked configuration #1209

Closed dachengx closed 1 year ago

dachengx commented 1 year ago

Before you submit this PR: make sure to put all operations-related information in a wiki-note, a PR should be about code and is publicly accessible

What does the code in this PR do / what does it improve?

The original factor is 5. This PR moves it to an untracked context configuration, because in reprocessing we might want to change it, but better without changing the source code.

It is trying to resolve: https://github.com/AxFoundation/strax/issues/490

This PR will not change the result of MergedS2s. It will not change the lineage either.

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

Notes on testing

All italic comments can be removed from this template.

coveralls commented 1 year ago

Coverage Status

coverage: 93.564% (+0.02%) from 93.541% when pulling 81adf1d4ff5560bf6e073f68069d4ab86ed6ff0b on merged_s2s_factor into a95280595c9b9cd76ab9839121c5b9f2a24df954 on master.

dachengx commented 1 year ago

Thanks, both of you!