XENONnT / straxen

Streaming analysis for XENON
BSD 3-Clause "New" or "Revised" License
20 stars 32 forks source link

Replace `z` from `z_naive` to `z_dv_corr` #1239

Closed dachengx closed 1 year ago

dachengx commented 1 year ago

What does the code in this PR do / what does it improve?

It replaces z to z_dv_corr, alt_s1_z to alt_s1_z_dv_corr and alt_s2_z to alt_s2_z_dv_corr. Because z_dv_corr already played a good correction for z.

Reference: https://xe1t-wiki.lngs.infn.it/doku.php?id=xenon:xenonnt:terliuk:drift_field_z_bias_correction

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

Notes on testing

All italic comments can be removed from this template.

coveralls commented 1 year ago

Coverage Status

coverage: 93.556% (+0.02%) from 93.534% when pulling d188688538ba9535a21f6d6777d1bdf741ec185c on z_dv_corr_to_z into 9a1e1fe19f0fdd599a128823a70865d8e7d19812 on master.

JYangQi00 commented 1 year ago

Thanks Dacheng, I will try and process some event_info on a run just to make sure z = z_dv_corr then accept!

dachengx commented 1 year ago

Thanks Dacheng, I will try and process some event_info on a run just to make sure z = z_dv_corr then accept!

Another thing to check is the change of hash. If a PR changes fields or values of fields, the hash must be changed.

The easiest way to change the hash is to change the version of the plugin. I am sure that the version is changed so will merge it. : )

JYangQi00 commented 1 year ago

Ah yup, the hash has been changed as well, sorry, I forgot to mention that.