XENONnT / straxen

Streaming analysis for XENON
BSD 3-Clause "New" or "Revised" License
20 stars 32 forks source link

Add pad-array protocol #1266

Closed jmosbacher closed 11 months ago

jmosbacher commented 1 year ago

Adds a URLConfig protocol wich will pad an array on the left or right or both with a configurable number of elements of the specified value

The protocol accepts the arguments pad_left, pad_right and pad_value to specify how many elements to add and what value to fill them with.

coveralls commented 1 year ago

Coverage Status

coverage: 93.696% (+0.02%) from 93.673% when pulling c6553df697edfccf1dbdd3ea7892c463ef3dc0eb on pad_array_protocol into 9bf6192f084fcae8bcfb6d90eaa20bc4c7aafc63 on master.

WenzDaniel commented 1 year ago

Looks good. Thanks for the quick implementation.

LuisSanchez25 commented 11 months ago

I was trying to test this protocol but I am a bit confused as to why it is in the xe1t_url_config and not in the normal url_config file, is there something I am missing here?

LuisSanchez25 commented 11 months ago

I successfully used the protocol to process some nv records so this is ready to be merged

jmosbacher commented 11 months ago

@LuisSanchez25 If you tested this, can you add your review? thanks.