search

XENONnT / straxen

Streaming analysis for XENON
BSD 3-Clause "New" or "Revised" License
20 stars 32 forks source link

Add top channel at peak_basics and above #1270

Closed shenyangshi closed 11 months ago

shenyangshi commented 11 months ago

Add n_top_channel to let s1 bdt get rid of the peaks computational-expensive area_per_channel dependence.

Resolve #1263.

shenyangshi commented 11 months ago
image image
coveralls commented 11 months ago

Coverage Status

coverage: 92.691% (+0.02%) from 92.669% when pulling da8a79bb9a742b32ee41548d6a961018861e0c04 on add_channel into 11cdb5c8ae7e27990a84c269c4c3e7778acae50b on master.

shenyangshi commented 11 months ago

@dachengx Do you think this is good to merge?

dachengx commented 11 months ago

@dachengx Do you think this is good to merge?

I suggest putting the new fields in another plugin. Because the already processed data will be affected.

shenyangshi commented 11 months ago

We'll start the global_v13 reprocessing soon, how about only merging this PR before releasing the new container? @jingqiangye

dachengx commented 11 months ago

We'll start the global_v13 reprocessing soon, how about only merging this PR before releasing the new container? @jingqiangye

Please discuss those in other place than public platform.