search

XENONnT / straxen

Streaming analysis for XENON
BSD 3-Clause "New" or "Revised" License
20 stars 32 forks source link

Add gps plugins #1285

Closed WenzDaniel closed 10 months ago

WenzDaniel commented 1 year ago

What does the code in this PR do / what does it improve?

Removed old syncing plugins and move GPS plugins from cutax to straxen.

WenzDaniel commented 1 year ago

I can fix the reviewdoc things, but not sure if I should wait for the pre-commit thing.

WenzDaniel commented 1 year ago

To make tests working we need to updated our test data to a run for which also GPS signals are available: https://github.com/XENONnT/straxen/blob/11cdb5c8ae7e27990a84c269c4c3e7778acae50b/straxen/test_utils.py#L16-L21 This should to be discussed in Team A.

coveralls commented 10 months ago

Coverage Status

coverage: 91.786% (-1.0%) from 92.822% when pulling 72e992d03cc95af098dec9302295ffbde4ab214f on add_gps_plugins into f23319dd37a23dddcc37156e62d112e36c8deafc on master.

WenzDaniel commented 10 months ago

The failing test has something to do with a numerical issue in the event pattern fit which cannot be solved right now.

WenzDaniel commented 10 months ago

Thanks Johanna, the MV plugins were just copied over from cutax. I will try to verify them again.