Update som classifcation

XENONnT / straxen

Streaming analysis for XENON

BSD 3-Clause "New" or "Revised" License

20 stars 32 forks source link

Update som classifcation #1300

Closed WenzDaniel closed 10 months ago

WenzDaniel commented 11 months ago

This PR will change the lineage for > peaklets!

What does the code in this PR do / what does it improve?

In this PR we change the SOM plugin such that it only returns a single data-type. It is based on the changes made in https://github.com/XENONnT/straxen/pull/1299. Further, we propagate the SOM and straxen classification, including the SOM subclasses, up to event basics for a better analysis.

I test processed a short run 025423 with the normal offline and SOM context.

WenzDaniel commented 10 months ago

Hmm @FaroutYLq which type of test do you have in mind? I can try to add some in #1299 because there we make actually all technical changes.

coveralls commented 10 months ago

coverage: 92.417% (+0.8%) from 91.571% when pulling 6e5d7b56d8bdfa66ef503234c4e4dafc2da2e565 on update_som_classifcation into c7916fc5b2edef131f758310210fb11a42397a4f on master.

JYangQi00 commented 10 months ago

I checked that the That peaklet_classification (SOM context) has the same straxen_type as the type of peaklet_classification (nT online context), and the same som fields as peaklet_classification_som (also in nT context). I did similar things as well for the peak and event basics as well, but only looking at the S1 SOM information (as intended by this PR). Everything looks good on my end and I think we are good to merge!