search

XENONnT / straxen

Streaming analysis for XENON
BSD 3-Clause "New" or "Revised" License
21 stars 32 forks source link

change integration window #1303

Closed marianarajado closed 8 months ago

marianarajado commented 8 months ago

What does the code in this PR do / what does it improve?

The updated code changes the integration window from [78, 116] to [78, 132] ADC

Can you briefly describe how it works?

This is the ADC window in which the waveform is expected to appear during an LED calibration. This change was necessary because the previous window did not contain the whole waveform (see this note)

GiovanniVolta commented 8 months ago

Hey Mariana, can you please add more information in the PR description? For bookkeeping

GiovanniVolta commented 8 months ago

Maybe we should also update the plugin version?

coveralls commented 8 months ago

Coverage Status

coverage: 92.81% (-0.01%) from 92.821% when pulling 7e556b69e277afa95f6b200836502e216b529b5b on change_window into 3b0567b623c124de156687e3b7424ef17eb6374f on master.

cwittweg commented 8 months ago

Can we merge this now or should we wait @dachengx @JYangQi00 ?

GiovanniVolta commented 8 months ago

I think we can proceed since this affects only led_calibration data and nothing else. Namely, the lineage of what ever is above records won't be touched