search

XENONnT / straxen

Streaming analysis for XENON
BSD 3-Clause "New" or "Revised" License
21 stars 32 forks source link

Add nopython #1319

Closed WenzDaniel closed 7 months ago

WenzDaniel commented 7 months ago

Update decorator for future numba

Reference: https://numba.readthedocs.io/en/stable/reference/deprecation.html#deprecation-of-object-mode-fall-back-behaviour-when-using-jit

dachengx commented 7 months ago

The error is because we have not dropped py3.8. We should wait for https://github.com/XENONnT/straxen/pull/1318.

coveralls commented 7 months ago

Coverage Status

Changes unknown when pulling cca3d92527374f99715173cd089ad71a9b8fb0cd on add_numba_no_python into on master.

dachengx commented 7 months ago

I see the failing test because I dropped wfsim from the requirement. https://github.com/XENONnT/straxen/actions/runs/7530878003/job/20498214152?pr=1319#step:9:289 Shall we make an issue or PR to move these tests or even the codes of contexts to wfsim?

dachengx commented 7 months ago

So I implemented https://github.com/XENONnT/straxen/pull/1320 and https://github.com/XENONnT/WFSim/pull/430.