Add S1 pattern likelihood for alt S1

zihaoxu98 commented 7 months ago

What does the code in this PR do / what does it improve?

This PR adds new fields of S1 pattern likelihoods for alt S1, which are "alt_s1_2llh", "alt_s1_top_2llh", "alt_s1_bottom_2llh". They could be useful for s1 single scatter cut.

Can you briefly describe how it works?

For alt S1's calculation, most of the changes are just with a prefix "alt_". The only exception is z, with prefix "alt_s1_".

Can you give a minimal working example (or illustrate with a figure)?

Same as before

Please include the following if applicable:

[x] Update the docstring(s)
[x] Update the documentation
[x] Tests to check the (new) code is working as desired.
[ ] Does it solve one of the open issues on github?

coveralls commented 7 months ago

coverage: 91.16% (+0.03%) from 91.135% when pulling 669d4375b56d9a72ae22d670d74ba7c001e30271 on alt_s1_llh into 4d6c2b7ba2954ceaa2601a7680c67b169e8c132c on master.

GiovanniVolta commented 7 months ago

May I suggest @minzhong98 as a reviewer for this PR? He is an expert on the S1 PL cut

minzhong98 commented 7 months ago

This PR looks good to me, thanks @zihaoxu98 !

dachengx commented 7 months ago

I think we still need to discuss whether we need this nice PR and more importantly the cut depends on it. So I would hesitate a bit about when to merge this.

zihaoxu98 commented 7 months ago

I agree. No rush on merging this PR

XENONnT / straxen