`_text_formats` should include txt but not text

XENONnT / straxen

Streaming analysis for XENON

BSD 3-Clause "New" or "Revised" License

21 stars 32 forks source link

`_text_formats` should include txt but not text #1324

Closed dachengx closed 6 months ago

dachengx commented 7 months ago

What does the code in this PR do / what does it improve?

When judging whether the file is a text file in resource_from_url, the text file should end with txt but not text.

https://github.com/XENONnT/straxen/blob/476bf1afd9dcf5015f6931c8dd1b27811ea6f1b9/straxen/common.py#L275

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

coveralls commented 7 months ago

coverage: 91.337% (+0.02%) from 91.316% when pulling 64ead4e6da8518726e977cc7deb10b42fd0dc3c6 on update_text_formats into b18e8f32fc0b3049bdffd24fa36ea78e12593ff5 on master.

yuema137 commented 6 months ago

It's a straightforward fix. Thanks