Remove `PeakSubtyping` from straxen - Githubissues

XENONnT / straxen

Streaming analysis for XENON

BSD 3-Clause "New" or "Revised" License

20 stars 32 forks source link

Remove `PeakSubtyping` from straxen #1365

Closed dachengx closed 5 months ago

dachengx commented 5 months ago

Before you submit this PR: make sure to put all operations-related information in a wiki-note, a PR should be about code and is publicly accessible

What does the code in this PR do / what does it improve?

Because it is duplicated also in https://github.com/XENONnT/s2_only

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

[ ] Update the docstring(s)
[ ] Update the documentation
[ ] Tests to check the (new) code is working as desired.
[ ] Does it solve one of the open issues on github?

Notes on testing

Until the automated tests pass, please mark the PR as a draft.
On the XENONnT fork we test with database access, on private forks there is no database access for security considerations.

All italic comments can be removed from this template.

coveralls commented 5 months ago

coverage: 91.403% (+0.1%) from 91.259% when pulling 6d9032799a446df611dcbf0f21d0b8261b1216a1 on rm_subtype_mask into 2e40607f3746b7588919b6925e9d0b6e8a379652 on master.