Stop using `self.config` because we do not use `strax.Option` - Githubissues

XENONnT / straxen

Streaming analysis for XENON

BSD 3-Clause "New" or "Revised" License

20 stars 32 forks source link

Stop using `self.config` because we do not use `strax.Option` #1413

Closed dachengx closed 2 weeks ago

dachengx commented 2 weeks ago

Before you submit this PR: make sure to put all operations-related information in a wiki-note, a PR should be about code and is publicly accessible

What does the code in this PR do / what does it improve?

Not so important changes.

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

[ ] Update the docstring(s)
[ ] Update the documentation
[ ] Tests to check the (new) code is working as desired.
[ ] Does it solve one of the open issues on github?

Notes on testing

Until the automated tests pass, please mark the PR as a draft.
On the XENONnT fork we test with database access, on private forks there is no database access for security considerations.

All italic comments can be removed from this template.

coveralls commented 2 weeks ago

coverage: 90.759% (-0.06%) from 90.817% when pulling e6f7eb1c1a66da2e30350dd5facf109c73eafeed on attribute_config into 5362dfa2938e6c152cb3234b40350df8131b0f6f on master.