search

XENONnT / straxen

Streaming analysis for XENON
BSD 3-Clause "New" or "Revised" License
20 stars 32 forks source link

Remove configuration `sum_waveform_top_array` from `MergedS2s` #1415

Closed dachengx closed 2 weeks ago

dachengx commented 2 weeks ago

Close: https://github.com/XENONnT/straxen/issues/1305

coveralls commented 2 weeks ago

Coverage Status

coverage: 90.824% (+0.02%) from 90.806% when pulling daf393010dfc03bb649ee898ae39c484602a9b53 on del_sum_waveform_top_array into c61848018f2fd49504e6d3b50de1343ecfb056b0 on master.

WenzDaniel commented 2 weeks ago

Sorry, but I need a bit more context why are we removing this? Do we not want to store the top waveform any longer?

WenzDaniel commented 2 weeks ago

Ah I saw you linked a PR.

dachengx commented 2 weeks ago

Sorry, but I need a bit more context why are we removing this? Do we not want to store the top waveform any longer?

Whether store it or not depends on whether there is a field "data_top" of peaklets.