XENONnT / straxen

Streaming analysis for XENON
BSD 3-Clause "New" or "Revised" License
21 stars 33 forks source link

Fix run_doc for led plugin #1462

Closed GiovanniVolta closed 3 weeks ago

GiovanniVolta commented 4 weeks ago

Before you submit this PR: make sure to put all operations-related information in a wiki-note, a PR should be about code and is publicly accessible

What does the code in this PR do / what does it improve?

I realized that there are run_ids with more than one comment, which will cause an error as it is right now. The first comment is always from the automatic script.

I have fixed that and I have added a check for verifying that the first comments has the right format.

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

Notes on testing

All italic comments can be removed from this template.

coveralls commented 4 weeks ago

Coverage Status

coverage: 90.219% (+0.02%) from 90.196% when pulling 5481a75b0577ad5c3c22a25255ea0bcb4cb4a835 on fix_run_doc_led into 79af57dfb3024f8bedde09c87bc6dd1b1d8251f2 on master.

GiovanniVolta commented 4 weeks ago

Here, @dachengx suggested changing the config in the test instead of adding a specific run_id for the led_calibration. Unfortunately, I don't know where to change it. If you prefer me to change the config, I need some help

GiovanniVolta commented 4 weeks ago

Ah, of course, the data are not stored so the test are still failing

GiovanniVolta commented 3 weeks ago

@dachengx @minzhong98 @MerzJohannes @yuema137 shall we proceed here?

GiovanniVolta commented 3 weeks ago

Thank you Dacheng <3