search

XENONnT / straxen

Streaming analysis for XENON
BSD 3-Clause "New" or "Revised" License
20 stars 32 forks source link

Scada calls fail if float times are used due to using len(str(start)) to do log10(start) #491

Closed kdund closed 3 years ago

kdund commented 3 years ago

The line here: https://github.com/XENONnT/straxen/blob/42d3f3839e0f771393c6dbbc61d8380320d87d71/straxen/scada.py#L233 uses the length of the string representation of the number to do log10 that works for ints, not for floats. If only ints are to be used, I think a separate test should be done for this.

JoranAngevaare commented 3 years ago

Should be fixed in #560