[Bug]: Inconsistency between framed and vanilla item frames

[Nathan-Fish]

Minecraft version

1.20

Forge version

47.2.0

FramedBlocks version

9.2.0

Describe the bug

Large inconsistencies between how vanilla item frames and framed item frames work, as said in the title. So far I've noted

• Modded items behave incorrectly, even when they're based on vanilla items (see Alex's Caves cave map)
• Renamed items don't show their names when looked at
• items don't keep their rotation when removed and replaced
• items in the frame can't be rotated unless clicked with an empty hand
• Mods like jade don't display the name item inside the frame when looked at

Glow item frames and framed glow item frames both work the same as their non-glowing counterparts

Specifically vanilla maps and their variants (like treasure or explorer maps) display as expected, however the bugs with naming or rotating still apply.

I'd imagine these are all caused by the same root issue since it seems like the frames aren't being recognized as item frames by other mods or vice versa. Not sure if this issue is easily fixable, but I thought I should bring it up.

Quick display of the collected bugs

Named Item not showing up

Rotation forgotten (the arrows were both rotated, then removed and replaced)

Infobox from Jade not showing contents

How to reproduce the bug

Use framed item frames with blocks with special attributes

Expected behavior

Item frame works exactly the same as its vanilla counterparts

Additional details

No response

Crash log

No response

[XFactHD]

Thank you for the detailed report.

To preface this, it's worth noting that the Framed Item Frame works very differently compared to the vanilla Item Frame. The main difference is that the vanilla one is an entity and the one from FramedBlocks is a block (this has technical reasons related to the infrastructure that makes the framing aspect of the mod work) that just tries it's hardest to not look like one. This has significant implications when it comes to how other mods react to it.

As for the listed issues:

• Renamed items: that's my mistake, I completely overlooked how the vanilla Item Frame handles custom item names, that's an easy fix
• Item rotation: same as above, I just made it reset the rotation when the item is removed since that seemed the most sensible to me, I'll adjust that
• Rotation with non-empty hand: that was kind of intentional since there would be some cases where it still wouldn't work with an item in hand, but I can see how that's akward compared to vanilla, I'll adjust that
• Jade: As mentioned in the preface, Jade has no way to know that this is an Item Frame and therefore won't handle it as one. I'll add Jade integration to fix that
• Modded items: items like the cave maps from Alex's Caves are completely custom things, they have no connection to the vanilla map item in terms of their implementation and as such they won't work out of the box. Adding integretation for them is possible, but would be blown out of proportion very quickly. I'll have to look into this a bit more, I could provide an API which other mods can implement to have their custom rendering on Framed Item Frames

I'll leave this issue open until I have a solution for the last point which I can point other mod authors at. In the meantime, feel free to comment with additional issues if you find more :)