search

XGovFormBuilder / digital-form-builder

Exploring how to quickly and easily design/prototype/deploy high quality digital forms for UK Gov. Based on the excellent work by DEFRA. Currently maintained by jen+forms@cautionyourblast.com at Caution Your Blast and a community collaboration between FCDO, HO, GDS, DfE, DIT, Version 1, UKHSA
https://digital-form-builder-designer.herokuapp.com/app
MIT License
55 stars 33 forks source link

Need to delete components and readd to reorder on page but wrong components get deleted. #758

Open delaynesr opened 2 years ago

delaynesr commented 2 years ago

Describe the bug When I need to reorder components I have to delete the one in the wrong place to add it again after. I open the one I want to delete, click delete then it goes back to my page and the one I said to delete is still there and the other one is gone.

To Reproduce Steps to reproduce the behavior:

  1. Click on component on page I want to delete
  2. Click delete at bottom of page
  3. return to page, see error
  4. Deleted component still there, unopened component beneath is gone

Expected behavior I expected the one that I deleted to be the one to disappear.

Screenshots If applicable, add screenshots to help explain your problem.

Repository

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

JamesBoadi commented 2 years ago

Which component failed to delete? Does this behaviour persist for all components?

delaynesr commented 2 years ago

Hi James,

I don't think it is related to the components. I just made a new page to check and it happens where there are 3 components (or more maybe, I only tested 3) and you try to delete the one in the middle. Then it automatically deletes the one at the bottom (the most recent component added) rather than the one in the middle (2nd component added).

Hope that makes sense.

Cheers, Delayne

On Mon, Feb 28, 2022 at 10:24 AM JamesBoadi @.***> wrote:

Which component failed to delete? Does this behaviour persist for all components?

— Reply to this email directly, view it on GitHub https://github.com/XGovFormBuilder/digital-form-builder/issues/758#issuecomment-1054107493, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXZQVVEUPMZ2KAKB5NPKWGLU5NEPNANCNFSM5ORWKEGQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

JamesBoadi commented 2 years ago

Yes I can see the issue now, currently components can only be deleted post order, not inorder. Probably a bug we will address in the future