search

XIA-LIYI / pe

0 stars 0 forks source link

UG: To name the parameter, it is better to take shorter name. #13

Open XIA-LIYI opened 3 years ago

XIA-LIYI commented 3 years ago

To name the parameter, it is better to take shorter name, i.e. PHONE_NUMBER can be phone, HOURLY_PAY can be pay. It is because the length of some commands exceed one line which looks messy and makes user lose interest in trying it.

image.png

nus-se-bot commented 3 years ago

Team's Response

PHONE_NUMBER is inherited from AB3. As for HOURLY_PAY, our team has chosen to prioritise clarity over the length of the parameter as pay could be hourly, weekly, monthly etc.

Severity is dropped to very low as this is more cosmetic and the meaning of the parameters, and hence the usage of the UG, are not affected.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: [replace this with your reason]