XITRIX / Moonlight-Switch

Moonlight port for Nintendo Switch
770 stars 47 forks source link

[Bug] Some keys not work on non-English keyboards #139

Closed yawin123 closed 1 month ago

yawin123 commented 4 months ago

Most of the keys do not work and, if your keyboard layout is not the standard English one, forget about being able to enjoy your language comfortably.

I thought I read that part of the code was based on that of Switch-NX. Well, in this program the keyboard does work well. The reason for this difference could be looked at.

I like this project, but it is unacceptable that when you press the comma key the PC receives the Print Screen key.

https://github.com/XITRIX/Moonlight-Switch/assets/5033480/569d0975-7fea-45a0-85f5-d8fd2d39250c

https://github.com/XITRIX/Moonlight-Switch/assets/5033480/955a76a9-b766-420e-b33e-9e54f03ea2d2

XITRIX commented 4 months ago

Thanks for the feedback, I'll try to check the issue. But do not use word "unacceptable", this project made on pure enthusiasm, I do not get paid for that.

XITRIX commented 4 months ago

Moonlight.nro.zip Could you use this build, please, enable "Show debugging view" in settings tab, and try to press the buttons that works incorrect to you. You should be able to see logs like "Keyboard keycode map from\to"

try to make the list like: Expected button - map from - map to

After that I'll try to find why this keys works incorrectly

yawin123 commented 4 months ago

I'm on it. I hope to have the complete list tomorrow.

yawin123 commented 4 months ago

Keys that I have found do not work

Key From To
, 41 256
. 55 46
Home 74 268
End 77 269
Page Up 75 266
Page Down 76 287
< 100 -1
> 225 340
' 45 45
¡ 46 61
+ 48 93
ñ 51 59

I think these are all the keys that are failing.

P.d.: This is the layout

XITRIX commented 4 months ago

Thanks, is it possible to extend it with wrong results? Sorry for not mentioning it earlier

yawin123 commented 4 months ago

In general they do not cause any results. At least in Sublime Text.

Page Up causes line breaks. , causes the same effect as Print Screen. The rest of the keys, as far as I remember, do nothing. Anyway, I'll look at it tomorrow just in case.

XITRIX commented 4 months ago

Could you please check does your keyboard even works on Switch, try to type some text in IP field i.e.? Because values "keys from" do not match with expected buttons at all, while it's raw data from LibNX.

For example your , button reported 41, while 41 is HidKeyboardKey_Escape

image
yawin123 commented 4 months ago

I tested with Moonlight-NX and it works ok. That is why I considered that the problem was in this program.

Tomorrow I will look to see if there is a homebrew text editor to check that everything responds as it should.

Specifically, in Moonlight-NX, the "," key correctly typed the "," character in the Sublime Text on my PC.

XITRIX commented 4 months ago

I was able to reproduce it by changing keyboard language in settings of Switch, keys not works even on normal English keyboard with Deutsch layout. Now it will be much easier to debug it for me

UP. Found the issue, for unknown reason, half of the special buttons just missed in mapper. I'll try to find all missing keys and push the new build

UP. Check this one Btw, some keys are still missed cause I have no proper keyboard to find their codes, if you'll find some, report them with codes, pls

yawin123 commented 4 months ago

Sorry it took so long. Work has kept me busy. I'll get to that now.

UP. Right now I only have a simplified and compact keyboard, so I may be missing some keys. I'll try to get a bigger keyboard.

Even so, I have found a single key that fails me. I assume there are changes in the new client because, when I press the keys, the debug window says nothing. So I can only offer you the information that I already offered you about that key:

Key From To
< 100 -1
XITRIX commented 4 months ago

Check this build, please. I think now it should work fine.

yawin123 commented 4 months ago

Indeed, it works very well and I have not found any keys that fail. What I have found, although I don't know if it would make more sense to open a new issue for it, is that the mouse wheel does not scroll.

I don't consider it a serious problem, but I thought it appropriate to report it.

XITRIX commented 4 months ago

Scrolling wheel is a painful topic, for me it works bad even in official Moonlight QT app, I'm not sure what I could do about it for now. Btw, it will not be an extra, if you'll create a separate issue for that, just not to forget that this issue exists.

So I'll close that issue when I'll release a new build

yawin123 commented 4 months ago

If you already know that there is a problem with the mouse wheel, I don't think it is necessary to open any issue.

Thank you very much for your dedication.

XITRIX commented 1 month ago

Released in v1.1.0