XITRIX / Moonlight-Switch

Moonlight port for Nintendo Switch
770 stars 47 forks source link

Gyroscope support wrong input. #164

Open orcavia opened 1 month ago

orcavia commented 1 month ago

Just tried the gyro support. It's now working smoothly, but there is wrong input compared to the original DS4. In my case, I tried it in the game HFW using yaw mode gyro.

For Y aiming, it's correct, but for X aiming, you should rotate (or tilt) the Switch to get the X value, while it should be yaw to the left/right.

XITRIX commented 1 month ago

Thanks for feedback, I'll check it

orcavia commented 1 month ago

you might be confused with my english 😅 so i made this simple animation that might help wrong Expected

orcavia commented 1 month ago

EDIT: I think your current implementation it's already correct for docked mode.

But for handheld mode it's feel strange when aiming for X axis Since the controller faced vertically unlike in docked mode which holds the controller faced horizontally.

For comparison try NS games that support gyro like Splatoon in handheld mode and then play PC games that support gyro on Moonlight. You will see the difference in how gyro (especially X value) work.

XITRIX commented 1 month ago

That's the best explanation of the problem I've ever saw :D

Thanks a lot, I understood what's the problem from the very beginning, I'll try to check it when I'll have time