search

XInTheDark / mzbot-v2

MZ Bot v2 for Discord!! Built with Python.
MIT License
3 stars 5 forks source link

Don't automatically install dependancies in `main.py` #19

Closed n0Oo0Oo0b closed 1 year ago

n0Oo0Oo0b commented 1 year ago

Automatically installing packages for the user with os.system should be avoided, as commands like pip install -r requirements.txt aren't guaranteed to work all the time (e.g. if there is more than one version of python installed or pip isn't in PATH). Just the requirements.txt file is enough to indicate the dependancies and you should tell the user how to install them instead of doing it for them.

XInTheDark commented 1 year ago

Automatically installing packages for the user with os.system should be avoided, as commands like pip install -r requirements.txt aren't guaranteed to work all the time (e.g. if there is more than one version of python installed or pip isn't in PATH). Just the requirements.txt file is enough to indicate the dependancies and you should tell the user how to install them instead of doing it for them.

Yes, I'll remove that in next commit, thanks for your kind reminder!