search

XKNX / xknx

XKNX - A KNX library written in Python
http://xknx.io/
MIT License
287 stars 104 forks source link

DPT 16.000 Character String (ASCII) #116

Closed TinusK closed 5 years ago

TinusK commented 6 years ago

It would be nice to be able to have a sensor type for strings. I would like to be able to display Diagnosis text messages from, for example, my heating actuators.

Ragards, Tinus

derandiunddasbo commented 5 years ago

I'd like to back this feature request. My alarm system outputs DPT 16.000 messages which I'd like to process in HA.

Is there any chance, this DPT gets implemented?

farmio commented 5 years ago

The base is already here: DPTString. If you know (or want to learn) some python you can try to extend RemoteValueSensor() and the HA component.

derandiunddasbo commented 5 years ago

Well, I "hacked" this into my local installation and it's working fine for me. But even it's only a couple of additional lines of code I have no idea if my implementation meets any requirements (naming, style, etc.) of the xknx project. And TBH I never opened a PR on Github so far. :-)

So I could contribute this, but a little help how to do this would be much appreciated.

Edit: And there are some things unclear for me regarding current implementation of the DTPString class. Where would I discuss them? Here or in a PR?

farmio commented 5 years ago

You can just fork the project, commit your changes and file a PR. We can have a look at the diff then. For a discussion either is fine. You can also join the discord channel (you'll find a link on xknx.io i think)

derandiunddasbo commented 5 years ago

Sorry, didn't have time this week to work on this. But IIRC, DTP 16.000 will be provided with fix #189? Thus I don't need to contribute my own fix anymore?

farmio commented 5 years ago

Right.