XKaguya / SpectatorChat

A mod that allows dead person use text to chat with other person.
GNU General Public License v3.0
1 stars 0 forks source link

Mod fails to load if ReviveCompany isn't installed #4

Open AdalynBlack opened 1 month ago

AdalynBlack commented 1 month ago

The main plugin file imports OPJosMod.ReviveCompany.CustomRpc, causing the mod to fail to load if ReviveCompany isn't installed. This import should be moved to a separate class, which is only loaded if the mod is detected

XKaguya commented 1 month ago

The main plugin file imports OPJosMod.ReviveCompany.CustomRpc, causing the mod to fail to load if ReviveCompany isn't installed. This import should be moved to a separate class, which is only loaded if the mod is detected

How this happen? I mean i've set the dependency into soft not hard. Which does not force need the mod if the mod didn't loaded. But anyway I'll get a fix. Thank you for repoy.

AdalynBlack commented 1 month ago

Setting it as a soft dependency means BepinEx will try to load it regardless of whether the other mod is present, but if it is, your mod will load after it BepInEx dependencies don't prevent issues if the code tries to reference a mod that isn't present

XKaguya commented 1 month ago

Setting it as a soft dependency means BepinEx will try to load it regardless of whether the other mod is present, but if it is, your mod will load after it BepInEx dependencies don't prevent issues if the code tries to reference a mod that isn't present

SpectatorChat.zip

Can you try this, I've deleted the reference of the OPJosMod.ReviveCompany.CustomRpc in the plugin.cs