Closed lognaturel closed 3 years ago
Merging #469 into master will decrease coverage by
0.01%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #469 +/- ##
==========================================
- Coverage 83.55% 83.53% -0.02%
==========================================
Files 25 25
Lines 3612 3608 -4
Branches 839 838 -1
==========================================
- Hits 3018 3014 -4
Misses 452 452
Partials 142 142
Impacted Files | Coverage Δ | |
---|---|---|
pyxform/xls2json.py | 77.89% <ø> (-0.14%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e5bb800...e78ea5c. Read the comment docs.
Why is this the best possible solution? Were any other approaches considered?
This is a routine update with not much choice. I think this is a good time to remove the repeat warning because the change happened several months ago and it's confusing to folks who didn't build forms before the change. I spent a bit of time seeing if there were any other outdated messages but I can't think of any.
What are the regression risks?
JavaRosa's calculation code was dramatically simplified. The latest release has bee in Collect betas for some time and has gone through careful review so I think the risk to validation behavior is low.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
tests_v1
nosetests
and verified all tests passblack pyxform
to format code