search

XLSForm / pyxform

A Python package to create XForms for ODK Collect.
BSD 2-Clause "Simplified" License
77 stars 134 forks source link

Display warning when using simserial or subscriberid #471

Closed lognaturel closed 3 years ago

lognaturel commented 3 years ago

Related docs issue: https://github.com/XLSForm/xlsform.github.io/pull/208

Web-based clients such as Enketo have never been able to read permanent unique identifiers like simserial or subscriberid. Neither have iOS clients for a long time. Android clients used to be able to access them but won't be able to do so from Play Store installs starting Nov 2020.

That means the only clients that will be able to access these identifiers are Android clients that target and run on Android versions < 11 (e.g. old versions of Collect).

@MartijnR pointed out at https://github.com/XLSForm/xlsform.github.io/pull/208#issuecomment-693499567 that maybe we should show an error when a user attempts to use these. Given that some folks might intentionally stay on old client versions to access this behavior, I have a slight preference for warning.

From https://github.com/XLSForm/pyxform/issues/471#issuecomment-693531176: Warning with text "Simserial is no longer supported on most devices. Only old versions of Collect on Android versions older than 11 still support it." (same for subscriberID)

MartijnR commented 3 years ago

Given that some folks might intentionally stay on old client versions to access this behavior, I have a slight preference for warning.

Yes, that's a good reason. Warning sounds sensible.

"Simserial is no longer supported on most devices. Only old versions of Collect on Android versions older than 11 still support it." (same for subscriberID)

KeynesYouDigIt commented 3 years ago

Should we also note the alternatives? eg "Consider using deviceId or Phone Number" ?