Why is this the best possible solution? Were any other approaches considered?
This adds warnings where other question type specific warnings are. This pattern is modelled after the special validation work used for 'audit' and 'calculate' question types.
I considered checking this information upstream in the survey creation process, but would have to re-divide the sheet into rows. Downstream, during question creation and final survey creation, is another place where warnings can be generated, but we have the information we need at the point where the warnings were added, so no point in working further down.
What are the regression risks?
I did modify constants.py - any modification of a global config represents some regression risk. However, values were only added, and only values that apply to my use case, and only under a name that does not conflict with another name, so I do not see any great risks.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
Closes #471
Why is this the best possible solution? Were any other approaches considered?
This adds warnings where other question type specific warnings are. This pattern is modelled after the special validation work used for 'audit' and 'calculate' question types.
I considered checking this information upstream in the survey creation process, but would have to re-divide the sheet into rows. Downstream, during question creation and final survey creation, is another place where warnings can be generated, but we have the information we need at the point where the warnings were added, so no point in working further down.
What are the regression risks?
I did modify constants.py - any modification of a global config represents some regression risk. However, values were only added, and only values that apply to my use case, and only under a name that does not conflict with another name, so I do not see any great risks.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
docs should already be set https://github.com/XLSForm/xlsform.github.io/pull/208/files
Before submitting this PR, please make sure you have:
tests_v1nosetestsand verified all tests passblack pyxformto format code