XLSForm / pyxform

A Python package to create XForms for ODK Collect.

BSD 2-Clause "Simplified" License

77 stars 134 forks source link

Fix 477 trigger in repeat #478

Closed gushil closed 3 years ago

gushil commented 3 years ago

Closes # Fix #477

Why is this the best possible solution? Were any other approaches considered?

The simplest one.

What are the regression risks?

None.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

[x] included test cases for core behavior and edge cases in tests_v1
[x] run nosetests and verified all tests pass
[x] run black pyxform to format code
[x] verified that any code or assets from external sources are properly credited in comments

codecov-io commented 3 years ago

Codecov Report

Merging #478 (53c23cf) into master (9520bd2) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #478   +/-   ##
=======================================
  Coverage   83.63%   83.63%           
=======================================
  Files          25       25           
  Lines        3641     3641           
  Branches      846      846           
=======================================
  Hits         3045     3045           
  Misses        452      452           
  Partials      144      144

Impacted Files	Coverage Δ
pyxform/question.py	`93.30% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9520bd2...53c23cf. Read the comment docs.

lognaturel commented 3 years ago

Thanks @MartijnR, @gushil!

pbowen-oc commented 3 years ago

@lognaturel - Do you have a timetable to tag a new version with this update?

MartijnR commented 3 years ago

@lognaturel proposed to release shortly with two other features still to be merged. I believe we're mainly waiting for me to review a PR.

On Fri, Nov 20, 2020 at 9:53 AM pbowen-oc notifications@github.com wrote:

@lognaturel https://github.com/lognaturel - Do you have a timetable to tag a new version with this update?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/XLSForm/pyxform/pull/478#issuecomment-731282381, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEZFFSQ7TJII5QNQK45EDTSQ2NIJANCNFSM4TUTIR5A .

-- Pushing data since 2012.

Enketo https://enketo.org | LinkedIn http://www.linkedin.com/company/enketo-llc | GitHub https://github.com/enketo | Twitter https://twitter.com/enketo | Blog http://blog.enketo.org

-- -- Revolutionizing data collection since 2012.

Enketo https://enketo.org/ | LinkedIn http://www.linkedin.com/company/enketo-llc | GitHub https://github.com/enketo | Twitter https://twitter.com/enketo | Blog http://blog.enketo.org/