Why is this the best possible solution? Were any other approaches considered?
Narrowest patch I could think of. I assume there is a major and minor version, and that both are ints. I also assume that the other version information doesn't matter.
What are the regression risks?
I remove the int wrappers in favor of the int() wrapping in the check that raises the exception
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
[X] included test cases for core behavior and edge cases in tests_v1
[X] run nosetests and verified all tests pass
[X] run black pyxform to format code
[X] verified that any code or assets from external sources are properly credited in comments
Resolves https://forum.getodk.org/t/problem-converting-with-xlsform-online-due-to-too-many-values-to-unpack/31163. This problem is occuring because the default Java on Ubuntu was upgraded to version "11.0.9.1" on 2020-11-04. Our code assumes no patch version.
This change will require a hotfix to pyxform.
Why is this the best possible solution? Were any other approaches considered?
Narrowest patch I could think of. I assume there is a major and minor version, and that both are ints. I also assume that the other version information doesn't matter.
What are the regression risks?
I remove the int wrappers in favor of the int() wrapping in the check that raises the exception
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
tests_v1nosetestsand verified all tests passblack pyxformto format code