search

XLSForm / pyxform

A Python package to create XForms for ODK Collect.
BSD 2-Clause "Simplified" License
80 stars 136 forks source link

Media in select from secondary instance is ignored #491

Closed lognaturel closed 3 years ago

lognaturel commented 3 years ago

Software and hardware versions

pyxform v1.2

Problem description

Media in select from secondary instance is ignored

Steps to reproduce the problem

Convert a form such as https://docs.google.com/spreadsheets/d/1js7lyH_4ZOnkmXiPjN-NrbE1Ky2AlsXL4tOWrAt1mZM/edit#gid=0. See that although an itext block is generated for the select, there's also a static label generated and that's what gets referred to in the select declaration.

Expected behavior

If a select from secondary instance has media defined for its choices, the label should be a jr:itext reference.

lognaturel commented 3 years ago

test_select_with_media_and_choice_filter_and_no_translations_generates_media seems to be testing this behavior...

lognaturel commented 3 years ago

Hurray, I was just on an old version.