I noticed in https://github.com/getodk/pyxform-http that we getting at "Error reading .xls file: Excel xlsx file; not supported" error when uploading an xlsx file. This only happened with our Docker build, not with our local pip build.
It seems that our Docker build's pip install runs setup.py which has a different version rules than requirements.in. The former allows xlrd>=1.1.0 which is dangerous because it means we can allow major version changes (and thus breaking behavior). In our case, our Docker build used xlrd v2.0 which doesn't support xlsx files.
This PR is a narrow change that changes setup.py's version behavior to match requirements.in.
I noticed in https://github.com/getodk/pyxform-http that we getting at "Error reading .xls file: Excel xlsx file; not supported" error when uploading an xlsx file. This only happened with our Docker build, not with our local pip build.
It seems that our Docker build's pip install runs
setup.py
which has a different version rules thanrequirements.in
. The former allowsxlrd>=1.1.0
which is dangerous because it means we can allow major version changes (and thus breaking behavior). In our case, our Docker build used xlrd v2.0 which doesn't support xlsx files.This PR is a narrow change that changes
setup.py
's version behavior to matchrequirements.in
.