XLSForm / pyxform

A Python package to create XForms for ODK Collect.
BSD 2-Clause "Simplified" License
77 stars 134 forks source link

Change error message if section name is equal to form name #511

Closed gushil closed 3 years ago

gushil commented 3 years ago

Closes #510

Why is this the best possible solution? Were any other approaches considered?

The simplest one.

What are the regression risks?

None.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

gushil commented 3 years ago

It looks like the changes made the old tests (the tests folder, not tests_v1) failed. Will look into it more.

codecov-io commented 3 years ago

Codecov Report

Merging #511 (4f1536f) into master (45ebf9f) will decrease coverage by 0.04%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #511      +/-   ##
==========================================
- Coverage   83.85%   83.81%   -0.05%     
==========================================
  Files          25       25              
  Lines        3691     3694       +3     
  Branches      859      860       +1     
==========================================
+ Hits         3095     3096       +1     
- Misses        452      453       +1     
- Partials      144      145       +1     
Impacted Files Coverage Δ
pyxform/survey.py 92.51% <100.00%> (-0.36%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 45ebf9f...4f1536f. Read the comment docs.

MartijnR commented 3 years ago

Thanks! This looks good to me after testing some forms. I think the reported reduction in code coverage is not an actual code coverage reduction (since all newly added code seems to be covered in the added test).

lognaturel commented 3 years ago

is not an actual code coverage reduction

I think it reports lines covered and the error message is split over three lines with only one tested...