MartijnR commented 3 years ago

I noticed there are 10 failing ODK Validate tests (step 2 of release steps), but that was the case in the previous version as well, and I'm guessing may have been the case for much longer. Are we just ignoring this?

codecov-io commented 3 years ago

Codecov Report

Merging #512 (ff09255) into master (435c933) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #512   +/-   ##
=======================================
  Coverage   83.81%   83.81%           
=======================================
  Files          25       25           
  Lines        3694     3694           
  Branches      860      860           
=======================================
  Hits         3096     3096           
  Misses        453      453           
  Partials      145      145

Impacted Files	Coverage Δ
pyxform/__init__.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 435c933...ff09255. Read the comment docs.

lognaturel commented 3 years ago

Yes, I've been not very good and just let those slide. I believe all of them just need slight reworks of the tests (e.g. using a valid function name, not having cycles, indexing into all repeats).

MartijnR commented 3 years ago

Thank you!

XLSForm / pyxform

Release v1.3.4 #512

Codecov Report