XLSForm / pyxform

A Python package to create XForms for ODK Collect.
BSD 2-Clause "Simplified" License
77 stars 134 forks source link

Fix error encountered while converting multi-language XLSForms to JSON #514

Closed DavisRayM closed 3 years ago

DavisRayM commented 3 years ago

Closes #513

Why is this the best possible solution? Were any other approaches considered?

The simplest option removes objects that can't be converted to JSON.

What are the regression risks?

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No

Before submitting this PR, please make sure you have:

codecov-io commented 3 years ago

Codecov Report

Merging #514 (f2515d3) into master (1c4a2ed) will increase coverage by 0.04%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #514      +/-   ##
==========================================
+ Coverage   83.81%   83.86%   +0.04%     
==========================================
  Files          25       25              
  Lines        3694     3699       +5     
  Branches      860      862       +2     
==========================================
+ Hits         3096     3102       +6     
+ Misses        453      452       -1     
  Partials      145      145              
Impacted Files Coverage Δ
pyxform/survey_element.py 95.06% <100.00%> (+0.52%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1c4a2ed...f2515d3. Read the comment docs.