Closed seadowg closed 3 years ago
Merging #519 (80fc54e) into master (7e86931) will increase coverage by
0.06%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #519 +/- ##
==========================================
+ Coverage 83.86% 83.92% +0.06%
==========================================
Files 25 25
Lines 3699 3713 +14
Branches 862 865 +3
==========================================
+ Hits 3102 3116 +14
Misses 452 452
Partials 145 145
Impacted Files | Coverage Δ | |
---|---|---|
pyxform/question_type_dictionary.py | 57.14% <ø> (ø) |
|
pyxform/constants.py | 100.00% <100.00%> (ø) |
|
pyxform/xls2json.py | 78.65% <100.00%> (+0.32%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7e86931...6a7b49d. Read the comment docs.
@MartijnR it occurs to me you might like (and it might be a good idea) to do a sanity check on this.
Thanks. I had a quick look at the tests. All looks good to me!
Closes #517
Why is this the best possible solution? Were any other approaches considered?
I'm not that familiar with the code base so would not be surprised if there's a better way of parsing the parameters than what I ended up with. Mostly just put this in following how other actions/questions were handled.
What are the regression risks?
Shouldn't be any really as most code refers to a new question type.
Before submitting this PR, please make sure you have:
tests_v1
nosetests
and verified all tests passblack pyxform
to format code