XLSForm / pyxform

A Python package to create XForms for ODK Collect.
BSD 2-Clause "Simplified" License
77 stars 134 forks source link

Warning for dynamic defaults now more annoying than helpful #526

Closed yanokwa closed 3 years ago

yanokwa commented 3 years ago

Closes #523

Why is this the best possible solution? Were any other approaches considered?

Narrowest fix possible

What are the regression risks?

No major ones.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

codecov-io commented 3 years ago

Codecov Report

Merging #526 (a9def04) into master (bee9654) will decrease coverage by 0.07%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #526      +/-   ##
==========================================
- Coverage   83.92%   83.84%   -0.08%     
==========================================
  Files          25       23       -2     
  Lines        3713     3554     -159     
  Branches      865      834      -31     
==========================================
- Hits         3116     2980     -136     
+ Misses        452      431      -21     
+ Partials      145      143       -2     
Impacted Files Coverage Δ
pyxform/xls2json.py 78.52% <ø> (-0.13%) :arrow_down:
pyxform/__init__.py
pyxform/utils.py

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bee9654...a9def04. Read the comment docs.