Node-set arguments are returned as absolute path. - Githubissues

XLSForm / pyxform

A Python package to create XForms for ODK Collect.

BSD 2-Clause "Simplified" License

77 stars 134 forks source link

Node-set arguments are returned as absolute path. #528

Closed gushil closed 3 years ago

gushil commented 3 years ago

Closes #525

Why is this the best possible solution? Were any other approaches considered?

The expansion of previous working solution.

What are the regression risks?

None.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

[x] included test cases for core behavior and edge cases in tests_v1
[x] run nosetests and verified all tests pass
[x] run black pyxform to format code
[x] verified that any code or assets from external sources are properly credited in comments

lognaturel commented 3 years ago

After conversation in #525, we've decided not to do this for now because it changes long-standing behavior. The effect is mostly on folks who use nested repeats but it may also result in performance issues in other contexts.