XLSForm / pyxform

A Python package to create XForms for ODK Collect.
BSD 2-Clause "Simplified" License
77 stars 134 forks source link

555: Add support for Python 3.9 #580

Closed lindsay-stevens closed 2 years ago

lindsay-stevens commented 2 years ago

Closes #555

Why is this the best possible solution? Were any other approaches considered?

A GitHub Actions yaml file was in place already with a release job for creating a build with Py3.8 and linux (ubuntu) and uploading it to PyPI. This PR updates the yaml to add jobs for:

The above more or less covers what the AppVeyor and CircleCI configurations are doing. So if this all looks good I could add removal of those CI dotfiles to this PR to close out #568 as well.

Some minor changes were required for Py3.9 compatibility. These are noted in e9c77ab and 3b21ce9, and involved removing a method call and a kwarg which were deprecated since Py3.2 and Py3.1 respectively.

What are the regression risks?

Unlikely, but maybe the test CI environments are slightly different. But the tests pass all the same.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No, it would only affect developers.

Before submitting this PR, please make sure you have:

codecov-commenter commented 2 years ago

Codecov Report

Merging #580 (3b21ce9) into master (bb2497d) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #580   +/-   ##
=======================================
  Coverage   83.59%   83.59%           
=======================================
  Files          25       25           
  Lines        3761     3761           
  Branches      930      930           
=======================================
  Hits         3144     3144           
  Misses        474      474           
  Partials      143      143           
Impacted Files Coverage Δ
pyxform/utils.py 78.08% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bb2497d...3b21ce9. Read the comment docs.

lindsay-stevens commented 2 years ago

./.circleci/config.yml and ./appveyor.yml have been deleted so these checks failed. ./.coveragerc also deleted.