Refactor PyxformTestCase.assertPyxformXform to use explicit keyword arguments instead of kwargs to avoid tests passing by mistake

XLSForm / pyxform

A Python package to create XForms for ODK Collect.

BSD 2-Clause "Simplified" License

80 stars 136 forks source link

Refactor PyxformTestCase.assertPyxformXform to use explicit keyword arguments instead of kwargs to avoid tests passing by mistake #597

Closed lindsay-stevens closed 8 months ago

lindsay-stevens commented 2 years ago

As mentioned here. If a developer misspells a keyword argument for a test assertion (such as error_contains instead of error__contains) the test can pass without any assertion being run at all. This can be confusing during development, and at worst lead to bugs staying pyxform for longer.