XLSForm / pyxform

A Python package to create XForms for ODK Collect.
BSD 2-Clause "Simplified" License
77 stars 134 forks source link

Set the parameters field/column default type to type dict #606

Closed ukanga closed 2 years ago

ukanga commented 2 years ago

Closes https://github.com/XLSForm/pyxform/issues/605

Why is this the best possible solution? Were any other approaches considered?

Minimal code change, works. See additional context and information on the issue https://github.com/XLSForm/pyxform/issues/605.

What are the regression risks?

None

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No

Before submitting this PR, please make sure you have:

lindsay-stevens commented 2 years ago

Hi @ukanga OK with the fix in general but I propose #607

lognaturel commented 2 years ago

Thanks! I do like the additions in #607 and hopefully you will as well.

ukanga commented 2 years ago

Closing in favour of #607