XLSForm / pyxform

A Python package to create XForms for ODK Collect.
BSD 2-Clause "Simplified" License
77 stars 134 forks source link

Fix linter check for black and isort not failing when changes required #631

Closed lindsay-stevens closed 1 year ago

lindsay-stevens commented 1 year ago

Noted here.

Linters black and isort returncode is 0 when fixes required and applied, so add arguments that make it returncode 1 when fixes required. Linters flake8 andpycodestyle` return 1 already.

Why is this the best possible solution? Were any other approaches considered?

It's the required arguments

What are the regression risks?

None, only relevant for GitHub actions

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No

Before submitting this PR, please make sure you have: