Linters black and isort returncode is 0 when fixes required and applied, so add arguments that make it returncode 1 when fixes required. Linters flake8 andpycodestyle` return 1 already.
Why is this the best possible solution? Were any other approaches considered?
It's the required arguments
What are the regression risks?
None, only relevant for GitHub actions
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No
Before submitting this PR, please make sure you have:
[x] included test cases for core behavior and edge cases in tests
[x] run nosetests and verified all tests pass
[x] run black pyxform tests to format code
[x] verified that any code or assets from external sources are properly credited in comments
Noted here.
Linters
black
andisort
returncode is 0 when fixes required and applied, so add arguments that make it returncode 1 when fixes required. Lintersflake8 and
pycodestyle` return 1 already.Why is this the best possible solution? Were any other approaches considered?
It's the required arguments
What are the regression risks?
None, only relevant for GitHub actions
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No
Before submitting this PR, please make sure you have:
tests
nosetests
and verified all tests passblack pyxform tests
to format code