Ignore media column if it is present

lognaturel commented 1 year ago

Makes marginal progress towards https://github.com/XLSForm/pyxform/issues/601

Why is this the best possible solution? Were any other approaches considered?

It's not a great solution towards the original issue but I think it's an improvement. We don't have an example of header validation and I don't have time to design a good solution right now.

What are the regression risks?

A user could presumably be expecting an exception there now. That seems fine to break.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

[x] included test cases for core behavior and edge cases in tests
[x] run nosetests and verified all tests pass
[x] run black pyxform tests to format code
[x] verified that any code or assets from external sources are properly credited in comments

lindsay-stevens commented 1 year ago

I don't have time to design a good solution right now

Is #601 a common or severe problem? The issue description and this PR don't seem bad to me, so some additional context might be useful for future reference.

lognaturel commented 1 year ago

Is https://github.com/XLSForm/pyxform/issues/601 a common or severe problem?

I don't think so. How about we close #601 after this and I make a doc change: https://github.com/getodk/docs/issues/1546

XLSForm / pyxform