660: nicer error about choices sheet when extension omitted in select_.._from_file

lindsay-stevens commented 10 months ago

Closes #660

Why is this the best possible solution? Were any other approaches considered?

Previously, an error about a missing sheet name may be thrown, e.g. if the form didn't contain any regular choices. This change explicitly checks for file extension, in order to show a nicer error message. The existing constants, aliases, and validation pattern are used.

What are the regression risks?

I think this is just an enhancement, since the old behaviour was confusing, and in both cases an error is raised.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No it's already documented in the template, just an easy mistake to make

Before submitting this PR, please make sure you have:

[x] included test cases for core behavior and edge cases in tests
[x] run nosetests and verified all tests pass
[x] run black pyxform tests to format code
[x] verified that any code or assets from external sources are properly credited in comments

lognaturel commented 10 months ago

Yay, @lindsay-stevens out here making my life so much better! (And hopefully that of other users, too 😊)

lognaturel commented 5 months ago

Just got this error again, such a big improvement!

XLSForm / pyxform