XLSForm / pyxform

A Python package to create XForms for ODK Collect.
BSD 2-Clause "Simplified" License
80 stars 136 forks source link

585: add test for allowed duplicate choices with translations #682

Closed lindsay-stevens closed 8 months ago

lindsay-stevens commented 8 months ago

Closes #585

Prior to always generating secondary instances, this scenario would have not output the duplicate choices, even if allowed. Now, itext are identified by choice position so it's not a problem. This test adds to the existing suite by using translations with the duplicates.

Why is this the best possible solution? Were any other approaches considered?

Since no code changes are needed, this test is just to improve coverage and verify the fix.

What are the regression risks?

None

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No

Before submitting this PR, please make sure you have: