Why is this the best possible solution? Were any other approaches considered?
It leads to all languages having a choice label of "Other" which is more similar to the behavior before pyxform 2 and will help with migration. A couple of implementation notes/questions are highlighted inline.
I also snuck in removing an error in case a select has both a choice filter and or_other. Now all selects are built on secondary instances so the choice filter case is not special.
What are the regression risks?
It's limited to or_other. I can imagine new issues around that behavior.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
[x] included test cases for core behavior and edge cases in tests
[x] run nosetests and verified all tests pass
[x] run black pyxform tests to format code
[x] verified that any code or assets from external sources are properly credited in comments
lognaturel
commented
5 months ago
Closes #683
Why is this the best possible solution? Were any other approaches considered?
It leads to all languages having a choice label of "Other" which is more similar to the behavior before pyxform 2 and will help with migration. A couple of implementation notes/questions are highlighted inline.
I also snuck in removing an error in case a select has both a choice filter and
or_other. Now all selects are built on secondary instances so the choice filter case is not special.What are the regression risks?
It's limited to or_other. I can imagine new issues around that behavior.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
testsnosetestsand verified all tests passblack pyxform teststo format code