689: translations not generated for choice list used with search() - Githubissues

XLSForm / pyxform

A Python package to create XForms for ODK Collect.

BSD 2-Clause "Simplified" License

77 stars 134 forks source link

689: translations not generated for choice list used with search() #690

Closed lindsay-stevens closed 5 months ago

lindsay-stevens commented 5 months ago

existing test case search_and_select didn't cover the multi-language case, which requires that itext is emitted for the inline selects.
approach and details described in Survey._redirect_is_search_itext.

Closes #689

Why is this the best possible solution? Were any other approaches considered?

What are the regression risks?

Does this change require updates to documentation? If so, please file an issue here and include the link below.

Before submitting this PR, please make sure you have:

[ ] included test cases for core behavior and edge cases in tests
[ ] run nosetests and verified all tests pass
[ ] run black pyxform tests to format code
[ ] verified that any code or assets from external sources are properly credited in comments

lognaturel commented 5 months ago

Thanks for this. This makes me kind of wish we weren't as obsessed with keeping old forms working but I continue to think it's important for our users.

Forgive me -- I'm going to go ahead and merge even though you marked this as draft! I have one suggestion for the tests that I'll do a follow-up PR for. I'd really like to put this release behind us and I think this is a very pragmatic approach and is easy to figure out with the comment.