Why is this the best possible solution? Were any other approaches considered?
It's easy to follow and brings back some logic that existed previously. I think pulling the regex into a function in utils makes usage easier to understand.
What are the regression risks?
This is a response to an unexpected regression. It feels very low-risk to me. Any possible risk is limited to the search() functionality.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
[x] included test cases for core behavior and edge cases in tests
[x] run nosetests and verified all tests pass
[x] run black pyxform tests to format code
[x] verified that any code or assets from external sources are properly credited in comments
Closes #694
Why is this the best possible solution? Were any other approaches considered?
It's easy to follow and brings back some logic that existed previously. I think pulling the regex into a function in utils makes usage easier to understand.
What are the regression risks?
This is a response to an unexpected regression. It feels very low-risk to me. Any possible risk is limited to the
search()functionality.Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
testsnosetestsand verified all tests passblack pyxform teststo format code